Skip to content

ci: Begin running ui tests with rust.debuginfo-level-tests=1 #144499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: Begin running ui tests with rust.debuginfo-level-tests=1 #144499

wants to merge 1 commit into from
+24 −3

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Jul 26, 2025 •
edited
Loading

To reduce risk of regressing on generating debuginfo e.g. in the form of ICE:s. This will also ensure that future ui tests work with different debuginfo levels. See #61117.

When I looked at run time for different CI jobs, x86_64-gnu-debug was far from the bottleneck, so it should be fine to make it perform more work.

A handful of tests are failing so we need to force debuginfo=0 on those for now.

We'll start small with debuginfo=1. We'll step up to debuginfo=2 once most (all?) tests can handle debuginfo=1. There are more failures with debuginfo=2 than with debuginfo=1.

@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jul 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@Enselic Enselic force-pushed the ci-debuginfo-level-tests branch from 8e58746 to 4996539 Compare July 26, 2025 13:33
@Enselic
Copy link
Member Author

Enselic commented Jul 26, 2025 •
edited
Loading

Can someone trigger the following try job please? Thanks in advance.

@bors2 try jobs=x86_64-gnu-debug

@rust-bors
Copy link

rust-bors bot commented Jul 26, 2025

@Enselic: 🔑 Insufficient privileges: not in try users

@lqd
Copy link
Member

lqd commented Jul 26, 2025

@bors try jobs=x86_64-gnu-debug

rust-bors bot added a commit that referenced this pull request Jul 26, 2025
@rust-bors
Auto merge of #144499 - Enselic:ci-debuginfo-level-tests, r=<try>
0b6a4a3 
ci: Begin running ui tests with `rust.debuginfo-level-tests=1`

try-job: x86_64-gnu-debug
@rust-bors
Copy link

rust-bors bot commented Jul 26, 2025

⌛ Trying commit 4996539 with merge 0b6a4a3…

To cancel the try build, run the command @bors try cancel.

@rust-bors
Copy link

rust-bors bot commented Jul 26, 2025

☀️ Try build successful (CI)
Build commit: 0b6a4a3 (0b6a4a3e360d2c8111499ac33a5aa1289e8fa845, parent: 133798f9fb2887bcccf1098937540e280dd58465)

@bors
Copy link
Collaborator

bors commented Aug 7, 2025

☔ The latest upstream changes (presumably #115746) made this pull request unmergeable. Please resolve the merge conflicts.

@Enselic
Copy link
Member Author

Enselic commented Aug 7, 2025

I will wait with resolving conflicts until after a first review.

davidtwco
davidtwco approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me after rebase

@davidtwco davidtwco added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2025
@Enselic
ci: Begin running ui tests with rust.debuginfo-level-tests=1
9637774 
To reduce risk of regressing on generating debuginfo e.g. in the form of
ICE:s. This will also ensure that future ui tests support different
debuginfo levels.

When I looked at run time for different CI jobs, **x86_64-gnu-debug**
was far from the bottle neck, so it should be fine to make it perform
more work.
@Enselic Enselic force-pushed the ci-debuginfo-level-tests branch from 4996539 to 9637774 Compare August 22, 2025 15:28
@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Enselic
Copy link
Member Author

Enselic commented Aug 22, 2025

Rebase was trivial as can be seen in the above range-diff (I love that new feature!).

I don't have r rights, so can someone do @bors r=davidtwco please? Or @bors delegate=Enselic which is even better in case there are other trivial problems to fix once we discover them. Thanks!

@bors
Copy link
Collaborator

bors commented Aug 22, 2025

@Enselic: 🔑 Insufficient privileges: Not in reviewers

@Enselic Enselic added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Enselic @rustbot @lqd @bors @davidtwco